Use PageFlowUtil.jsString to escape container path #522
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
labkey-jeckels
approved these changes
Mar 14, 2025
| pageConfig.addHandler(spanId, "click", "viewExperimentDetails(this,'" + container.getPath() + "', '" + id + "','" + detailsPage + "')"); | ||
| pageConfig.addHandler(spanId, "click", "viewExperimentDetails(this," | ||
| + PageFlowUtil.jsString(container.getPath()) | ||
| + ", '" + id + "', " |
Contributor
There was a problem hiding this comment.
Might as well handle them all the same way.
Suggested change
| + ", '" + id + "', " | |
| + ", " + PageFlowUtil.jsString(id) + ", " |
Collaborator
Author
There was a problem hiding this comment.
'id' is a non-null Integer so does not need to be quoted, I think.
I added some HTML-escaping in related code. If you could take another look that would be great.
Contributor
There was a problem hiding this comment.
You're right. I somehow thought it was a string.
…as parameter to a JS function.
…d by dropDownUtils.js
labkey-jeckels
approved these changes
Mar 20, 2025
Co-authored-by: Josh Eckels <jeckels@labkey.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale
Properly escape folder names passed as parameter to JS function, otherwise names containing single quotes cause JavaScript error.