-
Notifications
You must be signed in to change notification settings - Fork 29
docs: add post-process for external SDK types #2563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
f45241b to
0996305
Compare
| sed -i -E 's/_\[ProxyURL\]\(#proxyurl\) array_/_object array_/g' "${f}" | ||
| sed -i -E 's/_\[ProxyURL\]\(#proxyurl\)_/_object_/g' "${f}" | ||
| fi | ||
| done No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| done | |
| done | |
| echo "INFO: post-processing ${f}" | ||
| # Map external types to primitives for readability and to avoid dead anchors. | ||
| # AuthType -> string | ||
| sed -i -E 's/_\[AuthType\]\(#authtype\)_/_string_/g' "${f}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to maintain this list? Is it generated by some other scripts or maintained manually?
If it is maintained manually, I think we need some comments/documents to introduce how to keep them up to date.
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
0996305 to
e4c5b20
Compare
|
change to draft. We need more discussion about this. |
What this PR does / why we need it:
Which issue this PR fixes
Fixes #2564
Special notes for your reviewer:
PR Readiness Checklist:
Complete these before marking the PR as
ready to review:CHANGELOG.mdrelease notes have been updated to reflect significant changes