Skip to content

Conversation

@Just-Feeshy
Copy link
Contributor

This is extremely useful for my projects that use Kore V2 or V3, in which I want to support other libraries that rely on CMake or Meson build scripts. The Meson Exporter doesn't create an entire project; it just generates the needed arguments, include directories, and source files required for C, C++, and/or ObjC, which I use as a sub-directory for my main meson.build.

Copy link
Member

@RobDangerous RobDangerous left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some nitpicks to address. But I like this and want kmake to build bridges to similar tools.

systemDependendLibraries: any;
includes: {file: string, options: any}[];
excludes: string[];
subprojects: string[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do already have Project.subProjects.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, I forgot to remove this as I was referencing mainly the CMakeExporter.ts and didn't seesubProjects as at the time of development, I had my vim search to consider whether the character was capital or lowercase.

package.json Outdated
@@ -0,0 +1,5 @@
{
"dependencies": {
"typescript": "^5.8.3"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package.json file (that has typescript as a devDependency) is in the kmake subdirectory.

@Just-Feeshy
Copy link
Contributor Author

I removed the nitpicks, at least I think I did.

@RobDangerous
Copy link
Member

I removed the nitpicks, at least I think I did.

Almost :) The subprojects element still exists (the "Files changed" tab is convenient for checking the end result of a pull request).

@Just-Feeshy
Copy link
Contributor Author

That is very idiotic of me, I'm so sorry! I can't believe I forgot to remove it.

@RobDangerous
Copy link
Member

Please don't get worked up about a simple oversight and... thank you very much!

@RobDangerous RobDangerous merged commit b40cfa1 into Kode:main Sep 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants