-
Notifications
You must be signed in to change notification settings - Fork 16
Added MesonExporter.ts
#64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
RobDangerous
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some nitpicks to address. But I like this and want kmake to build bridges to similar tools.
kmake/src/Project.ts
Outdated
| systemDependendLibraries: any; | ||
| includes: {file: string, options: any}[]; | ||
| excludes: string[]; | ||
| subprojects: string[]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We do already have Project.subProjects.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I forgot to remove this as I was referencing mainly the CMakeExporter.ts and didn't seesubProjects as at the time of development, I had my vim search to consider whether the character was capital or lowercase.
package.json
Outdated
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "dependencies": { | |||
| "typescript": "^5.8.3" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The package.json file (that has typescript as a devDependency) is in the kmake subdirectory.
|
I removed the nitpicks, at least I think I did. |
Almost :) The subprojects element still exists (the "Files changed" tab is convenient for checking the end result of a pull request). |
|
That is very idiotic of me, I'm so sorry! I can't believe I forgot to remove it. |
|
Please don't get worked up about a simple oversight and... thank you very much! |
This is extremely useful for my projects that use Kore V2 or V3, in which I want to support other libraries that rely on CMake or Meson build scripts. The Meson Exporter doesn't create an entire project; it just generates the needed arguments, include directories, and source files required for C, C++, and/or ObjC, which I use as a sub-directory for my main
meson.build.