Skip to content

Add OG tags to index.html #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
donmccurdy wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add OG tags to index.html #113

donmccurdy wants to merge 1 commit into from

Conversation

@donmccurdy
Copy link

@donmccurdy donmccurdy commented Jun 29, 2021

Fixes #112.

@donmccurdy
Copy link
Author

donmccurdy commented Jun 29, 2021 •
edited
Loading

@Khronoswebmaster would it be better for us to copy the image (https://www.khronos.org/assets/uploads/apis/2019-gltf-ecosystem_1_17.jpg) into this repository? Or maybe there's a better image for this? I'm guessing it's better to host the image here, but it seems like this image changes often, too.

FYI the glTF landing page (https://www.khronos.org/gltf/) has some similar issues when posted to social media sites:

Screen Shot 2021-06-28 at 5 36 54 PM

@KhronosWebservices
Copy link
Member

KhronosWebservices commented Jun 29, 2021

The glTF image gets updated fairly regularly (17 in the name is the version number). If you are open to updating it on GitHub, we can include you in update notifications. Options on how to best handle this are welcome.

Seems the template didn't get proper social media treatment when we moved to the dark side... is this style you are looking for?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Consider adding OpenGraph meta tags

3 participants

@donmccurdy @KhronosWebservices