Skip to content

Conversation

@jaredly
Copy link
Contributor

@jaredly jaredly commented Aug 4, 2021

Summary:

we didn't have a prettierrc set up

Test plan:

jaredly added 2 commits August 4, 2021 10:46
If it's absent, the fall back to the method that might give false positives.

Issue: https://khanacademy.atlassian.net/browse/FEI-3796
@jaredly jaredly requested a review from jeresig August 4, 2021 16:07
@jaredly jaredly self-assigned this Aug 4, 2021
@jaredly jaredly requested a review from lillialexis August 4, 2021 16:07
Copy link
Member

@jeresig jeresig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Base automatically changed from changed-better to main August 4, 2021 16:08
@jaredly
Copy link
Contributor Author

jaredly commented Aug 4, 2021

The parent pull-request ([#14]](#14)) has been merged into main, but this branch (prettier) now has conflicts with the new base branch. These conflicts must be resolved before checks can complete on this pull-request.

Copy link
Contributor

@lillialexis lillialexis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder why you're suddenly getting so many flow-coverage errors?

@jaredly jaredly merged commit 97ebb35 into main Aug 4, 2021
@jaredly jaredly deleted the prettier branch August 4, 2021 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants