Skip to content

Fix: Accept numeric version field in AnkiConnect API requests #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mallomar wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Accept numeric version field in AnkiConnect API requests #90

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
59de0b5
Fix: Accept numeric version field in API requests
mallomar Oct 7, 2025
23955c0
Make get_version handle both numeric and string types
mallomar Oct 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 25 additions & 7 deletions app/src/main/java/com/kamwithk/ankiconnectandroid/request_parsers/Parser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,20 +21,38 @@ public class Parser {
public static Gson gson = new GsonBuilder().setPrettyPrinting().serializeNulls().create();
public static Gson gsonNoSerialize = new GsonBuilder().setPrettyPrinting().create();

public static JsonObject parse(String raw_data) {
return JsonParser.parseString(raw_data).getAsJsonObject();
}
public static JsonObject parse(String raw_data) {
// Use a more lenient parser that accepts both numeric and string version fields
com.google.gson.stream.JsonReader reader = new com.google.gson.stream.JsonReader(
new java.io.StringReader(raw_data)
);
reader.setLenient(true);
return JsonParser.parseReader(reader).getAsJsonObject();
}

public static String get_action(JsonObject data) {
return data.get("action").getAsString();
}

public static int get_version(JsonObject data, int fallback) {
if (data.has("version")) {
return data.get("version").getAsInt();
public static int get_version(JsonObject data, int fallback) {
if (data.has("version")) {
JsonElement versionElement = data.get("version");
// Handle both string and numeric version fields
if (versionElement.isJsonPrimitive()) {
com.google.gson.JsonPrimitive primitive = versionElement.getAsJsonPrimitive();
if (primitive.isNumber()) {
return primitive.getAsInt();
} else if (primitive.isString()) {
try {
return Integer.parseInt(primitive.getAsString());
} catch (NumberFormatException e) {
return fallback;
}
}
}
return fallback;
}
return fallback;
}

public static String getDeckName(JsonObject raw_data) {
return raw_data.get("params").getAsJsonObject().get("note").getAsJsonObject().get("deckName").getAsString();
Expand Down