Fix hub detection accuracy and unify dependency resolution #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
- Fix false hub detection for package-level imports (Go, Python, Rust, etc.) Only count imports that resolve to exactly one file. Package/module imports that resolve to multiple files are now correctly skipped. - Fix atomic save "remove" artifacts in session history When editors do write-to-temp + rename, fsnotify sees REMOVE events. Now checks if "removed" files still exist and relabels them as "edited". - Unify dependency resolution by removing duplicate findInternalDeps() The render/depgraph.go had its own buggy import resolution that incorrectly parsed file extensions (e.g., "./utils/helper.js" → "js" instead of "helper"). Now uses scanner.BuildFileGraph() for consistent, accurate resolution across --deps output, hooks, MCP tools, and watch daemon. - Filter deps to displayed files in --diff mode When using --deps --diff, dependency counts and hub info now only reflect files in the diff, not the entire repo. - Remove ~130 lines of duplicate/buggy code from render/depgraph.go 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
JordanCoin
force-pushed
the
fix-hub-detection-accuracy
branch
from
9e8f4b4 to
d472dea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
findInternalDeps()from render/depgraph.go, now usesscanner.BuildFileGraph()everywhereProblem
--depsoutput used different (buggy) resolution logic than hooks/MCP/daemonSolution
filegraph.go: Only count imports that resolve to exactly 1 file. Package imports that resolve to N files are skipped.hooks.go: Check if "REMOVE" files still exist, relabel as "edited" if sodepgraph.go: ReplacefindInternalDeps()withBuildFileGraph()call, removing ~130 lines of duplicate codeTest plan
--depsand hook outputs now consistent🤖 Generated with Claude Code