Update warning about malicious Discord server to be bigger since its small #367
Conversation
…would benefit because I almost missed it
There was a problem hiding this comment.
Pull request overview
This PR enhances the visibility of a critical security warning about a malicious Discord server by increasing the emphasis of the warning message through larger text and emoji markers.
- Changes the warning from a plain
<a>tag to an<h1>heading with warning emojis (‼️ )
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| <h3 align="center">FarmHelper V2</h3> | ||
| <p align="center"> | ||
| <a>There is no official Discord server. discord.gg/jellylab is A STOLEN, MALICIOUS server! DO NOT JOIN!</a> | ||
| <h1>‼️There is no official Discord server. discord.gg/jellylab is A STOLEN, MALICIOUS server! DO NOT JOIN!‼️</h1> |
There was a problem hiding this comment.
Using an h1 tag nested inside a paragraph element is not valid HTML. The h1 element is a block-level element and should not be placed inside a p element, which expects phrasing content. Consider using a strong or b tag with appropriate styling instead, or restructure the HTML to place the heading outside the paragraph.
| <h3 align="center">FarmHelper V2</h3> | ||
| <p align="center"> | ||
| <a>There is no official Discord server. discord.gg/jellylab is A STOLEN, MALICIOUS server! DO NOT JOIN!</a> | ||
| <h1>‼️There is no official Discord server. discord.gg/jellylab is A STOLEN, MALICIOUS server! DO NOT JOIN!‼️</h1> |
There was a problem hiding this comment.
The warning message would be more accessible with proper semantic markup. Consider using a div with a strong emphasis element instead of nested h1 within p tags. Additionally, relying solely on emojis for emphasis may not work well with screen readers - consider adding aria-label or using text-based emphasis markers as well.
|
bro aint no way copilot rosted my pr over html layout 😭 |
1 participant
…would benefit because I almost missed it