#69 Improve publish delivering to subscribers part 4 #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…livering-to-subscribers
…-publish-delivering-to-subscribers-part-2
…livering-to-subscribers-part-2 # Conflicts: # core-service/src/main/java/javasabr/mqtt/service/publish/handler/impl/Qos1MqttPublishOutMessageHandler.java # core-service/src/main/java/javasabr/mqtt/service/publish/handler/impl/Qos2MqttPublishOutMessageHandler.java # core-service/src/main/java/javasabr/mqtt/service/publish/handler/impl/TrackableMqttPublishOutMessageHandler.java # core-service/src/main/java/javasabr/mqtt/service/session/impl/InMemoryProcessingPublishes.java
…improve-publish-delivering-to-subscribers-part-3
…livering-to-subscribers-part-3 # Conflicts: # network/src/main/java/javasabr/mqtt/network/message/out/PublishReleaseMqtt311OutMessage.java
…improve-publish-delivering-to-subscribers-part-4
…livering-to-subscribers-part-4
Test Coverage Report
|
crazyrokr
requested changes
Dec 9, 2025
core-service/src/main/java/javasabr/mqtt/service/AclService.java
Outdated
Show resolved
Hide resolved
| handleNotSupportedRetain(user); | ||
| return true; | ||
| } | ||
| return false; |
Collaborator
There was a problem hiding this comment.
It seems like the following style is morу understandable to the reader, don't you think so?
if (retain && !connectionConfig.retainAvailable()) {
log.warning(user.clientId(), "[%s] 'RETAIN' option is not supported"::formatted);
handleNotSupportedRetain(user);
return true;
} else {
return false;
}
Owner
Author
There was a problem hiding this comment.
@crazyrokr I still totally don't understand why it's better
| return true; | ||
| } | ||
| } | ||
| return false; |
Collaborator
There was a problem hiding this comment.
The same as the comment above
JavaSaBr
changed the title
JavaSaBr
changed the title
crazyrokr
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#69