-
Notifications
You must be signed in to change notification settings - Fork 4
IvorySQL Operator Release 5.1 #82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -19,19 +19,19 @@ spec: | |
| - name: IVORY_DEBUG | ||
| value: "true" | ||
| - name: RELATED_IMAGE_IVORY_18 | ||
| value: "docker.io/ivorysql/ivorysql:ubi8-5.0-5.0-1" | ||
| value: "docker.io/ivorysql/ivorysql:ubi9-5.1-5.1-1" | ||
| - name: RELATED_IMAGE_PGADMIN | ||
| value: "docker.io/ivorysql/pgadmin:ubi8-9.9-5.0-1" | ||
| value: "docker.io/ivorysql/pgadmin:ubi9-9.9-5.1-1" | ||
| - name: RELATED_IMAGE_PGBACKREST | ||
| value: "docker.io/ivorysql/pgbackrest:ubi8-2.56.0-5.0-1" | ||
| value: "docker.io/ivorysql/pgbackrest:ubi9-2.56.0-5.1-1" | ||
| - name: RELATED_IMAGE_PGBOUNCER | ||
| value: "docker.io/ivorysql/pgbouncer:ubi8-1.23.0-5.0-1" | ||
| value: "docker.io/ivorysql/pgbouncer:ubi9-1.24.0-5.1-1" | ||
| - name: RELATED_IMAGE_PGEXPORTER | ||
| value: "docker.io/ivorysql/postgres-exporter:ubi8-0.17.0-5.0-1" | ||
| value: "docker.io/ivorysql/postgres-exporter:ubi9-0.17.0-5.1-1" | ||
| - name: RELATED_IMAGE_PGUPGRADE | ||
| value: "registry.developers.crunchydata.com/crunchydata/crunchy-upgrade:ubi8-5.3.1-0" | ||
| value: "registry.developers.crunchydata.com/crunchydata/crunchy-upgrade:ubi9-5.3.1-0" | ||
| - name: RELATED_IMAGE_POSTGRES_18_GIS_3.5 | ||
| value: "docker.io/ivorysql/ivorysql-postgis:ubi8-3.5-5.0-1" | ||
| value: "docker.io/ivorysql/ivorysql-postgis:ubi9-3.5-5.1-1" | ||
|
Comment on lines
+22
to
+34
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: # Search for all pgBackRest image references with different tag variants
echo "=== pgBackRest image references ==="
rg -n 'pgbackrest:ubi9-2\.56' . --type yaml
echo ""
echo "=== PostGIS image references ==="
rg -n '(ivorysql-postgis|postgis):ubi9-3\.5' . --type yaml
echo ""
echo "=== All RELATED_IMAGE_PGBACKREST references ==="
rg -n 'RELATED_IMAGE_PGBACKREST' . --type yaml -A 1Repository: IvorySQL/ivory-operator Length of output: 2302 🏁 Script executed: # Search for PostGIS references in workflow files
echo "=== PostGIS references in workflows ==="
rg -n 'postgis' .github/workflows --type yaml -i
echo ""
echo "=== Complete pgBackRest variant count ==="
rg 'pgbackrest:ubi9-2\.56' . --type yaml | wc -l
echo "With .0 (manager configs):"
rg 'pgbackrest:ubi9-2\.56\.0' . --type yaml | wc -l
echo "Without .0 (example clusters):"
rg 'pgbackrest:ubi9-2\.56-' . --type yaml | rg -v '2\.56\.0' | wc -lRepository: IvorySQL/ivory-operator Length of output: 498 Manager RELATED_IMAGE_ values match the new ubi9/5.1 image set; resolve PostGIS and pgBackRest image tag inconsistencies* The RELATED_IMAGE_* env vars are consistently bumped to the ubi9‑5.1 images, but two inconsistencies exist across the codebase:
Standardize these to a single canonical image/tag across manager, examples, and workflows to ensure consistency between operator deployments, tests, and documentation. 🤖 Prompt for AI Agents |
||
| securityContext: | ||
| allowPrivilegeEscalation: false | ||
| capabilities: { drop: [ALL] } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -27,9 +27,9 @@ spec: | |
| - name: IVORY_DEBUG | ||
| value: "true" | ||
| - name: RELATED_IMAGE_IVORY_5 | ||
| value: "docker.io/ivorysql/ivorysql:ubi8-5.0-5.0-1" | ||
| value: "docker.io/ivorysql/ivorysql:ubi9-5.1-5.1-1" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chain🏁 Script executed: # First, let's check the target file around line 30-32
echo "=== Checking examples/kustomize/install/manager/manager.yaml ==="
sed -n '28,35p' examples/kustomize/install/manager/manager.yamlRepository: IvorySQL/ivory-operator Length of output: 431 🏁 Script executed: # Search for all pgbackrest image references in the codebase
echo "=== Finding all pgbackrest image references ==="
rg "pgbackrest:" --type yaml -A 1 -B 1Repository: IvorySQL/ivory-operator Length of output: 14395 🏁 Script executed: # Also check the other files mentioned in the review comment
echo "=== Checking examples/kustomize/gcs/ivory.yaml ==="
grep -n "pgbackrest:" examples/kustomize/gcs/ivory.yaml
echo "=== Checking examples/kustomize/azure/ivory.yaml ==="
grep -n "pgbackrest:" examples/kustomize/azure/ivory.yaml
echo "=== Checking examples/ivorycluster/ivorycluster.yaml ==="
grep -n "pgbackrest:" examples/ivorycluster/ivorycluster.yaml
echo "=== Checking examples/kustomize/high-availability/ha-ivory.yaml ==="
grep -n "pgbackrest:" examples/kustomize/high-availability/ha-ivory.yamlRepository: IvorySQL/ivory-operator Length of output: 619 🌐 Web query:
💡 Result: Short answer: pgBackRest images use plain version tags (e.g., 2.56.0). There is no separate ":2.56.0-ubi9" tag — some vendor images (e.g., Percona's percona-pgbackrest:2.56.0) are built FROM a UBI9/ubi9-minimal base (UBI9 appears in the image metadata), but the registry tag itself is just the pgBackRest version. [1][2][3] Sources:
Standardize pgBackRest image tag format across manager.yaml files.
🤖 Prompt for AI Agents |
||
| - name: RELATED_IMAGE_PGBACKREST | ||
| value: "docker.io/ivorysql/pgbackrest:ubi8-2.56.0-5.0-1" | ||
| value: "docker.io/ivorysql/pgbackrest:ubi9-2.56.0-5.1-1" | ||
|
|
||
| securityContext: | ||
| allowPrivilegeEscalation: false | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion | 🟠 Major
🧩 Analysis chain
🏁 Script executed:
Repository: IvorySQL/ivory-operator
Length of output: 1694
🏁 Script executed:
Repository: IvorySQL/ivory-operator
Length of output: 2145
🏁 Script executed:
Repository: IvorySQL/ivory-operator
Length of output: 1599
Mismatched GIS env var names and image repositories between CI and manager configuration
The workflow uses
RELATED_IMAGE_IVORY_18_GIS_3.5pointing todocker.io/ivorysql/postgis:ubi9-3.5-5.1-1(line 127), whileconfig/manager/manager.yamldefinesRELATED_IMAGE_POSTGRES_18_GIS_3.5pointing todocker.io/ivorysql/ivorysql-postgis:ubi9-3.5-5.1-1. This creates divergence in both the env var names (IVORY vs POSTGRES prefix) and the image repositories (postgis vs ivorysql-postgis).Align the env var names and image repository references across files to ensure CI and deployed behavior remain consistent.