[MOB-10033] Example App: inbox #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and update navigation types
…xTrigger in IterableAppProps, update context provider, and initialize state
…tomizations and create Inbox.constants for styling Fixed main iterable app so that constants are property being exported.
…e for unread messages, update navigation routes, and enhance state management in useIterableApp
…MOB-10033-add-inbox
…MOB-10033-add-inbox
Base automatically changed from
2.0.0-alpha/MOB-10032-add-login-page
to
2.0.0-alpha/master
November 21, 2024 17:04
evantk91
reviewed
Nov 25, 2024
Contributor
evantk91
left a comment
evantk91
left a comment
There was a problem hiding this comment.
Had a few clarifications. But otherwise looking good.
| handleMessageSelect={(messageId: string, i: number) => | ||
| handleMessageSelect(messageId, i) | ||
| } | ||
| handleMessageSelect={handleMessageSelect} |
Contributor
There was a problem hiding this comment.
Whats the reason for this change?
Contributor
Author
There was a problem hiding this comment.
Cleanliness/readability.
Contributor
There was a problem hiding this comment.
Gotcha. Can the same be done for deleteRow?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 JIRA Ticket(s) if any
✏️ Description
Added an inbox to the example app
Testing
yarn installScreenshots
iOS
Android