Allow linking against system libraries via pkg-config #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WOnder93
force-pushed
the
system-quazip
branch
from
ff1b143 to
ad5584b
Compare
Contributor
Author
|
I updated the PR to use the new QuaZip development interface (where we can take advantage of pkgconfig) used in version 1.0 and later. Previous version would work against the older 0.x releases. |
WOnder93
force-pushed
the
system-quazip
branch
from
ad5584b to
3d3178c
Compare
WOnder93
changed the title
Contributor
Author
|
Updated to also use pkgconfig for zlib, which is used directly by |
Contributor
Author
|
@Isarhamster Any feedback to this and the other PR? I'm currently carrying these as downstream patches in Fedora [1]. It would be nice to have them included in an official release. |
WOnder93
force-pushed
the
system-quazip
branch
from
3d3178c to
7ef6fc8
Compare
WOnder93
force-pushed
the
system-quazip
branch
from
7ef6fc8 to
3cb99bc
Compare
When 'link_pkgconfig' is added to CONFIG, chessx will now use pkg-config to dynamically link against the quazip and zlib libraries installed on the system, rather than bundling quazip or guessing the header file location. Default behavior remains unchanged. Signed-off-by: Ondrej Mosnáček <omosnacek@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 'link_pkgconfig' is added to CONFIG, chessx will now use pkg-config
to dynamically link against the quazip and zlib libraries installed on
the system, rather than bundling quazip or guessing the header file
location. Default behavior remains unchanged.