LaneSwitch UX #194
Open
LaneSwitch UX #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ less opaque + remove gradient
Member
|
A way this could act as a fix for the linked issue is having an optional toggle that disables the interactions entierly. |
Contributor
Author
|
so by this you mean disable all interactivity for the laneswitches or toggle between the old and new changes? |
Member
|
fully disable clicking and hovering |
flustix
requested changes
Dec 6, 2025
Member
flustix
left a comment
flustix
left a comment
There was a problem hiding this comment.
Also go over most files and check for style warnings and such. EditorLaneSwitchEvent gives me 26 warnings.
Comment on lines
+12
to
+14
| [JsonProperty("laneswitch_interact")] | ||
| public bool LaneSwitchInteraction { get; set; } | ||
|
|
Member
There was a problem hiding this comment.
Set default to true so that old keymaps have the right value.
|
|
||
| public LaneSwitchEvent Event { get; } | ||
|
|
||
| private static Colour4 defaultColor = Colour4.FromHex("#FF5555"); // Theme.LaneSwitch is a different color. |
Member
|
Additionally, having the stripes only show up when the animation time is 0 feels a bit wrong. Possibly show them after the gradient fades out? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Meant to address:
Though if it's considered a fix for this is up to debate. (No linked issue)
Because it seems like an ambiguous issue.
Nlaneswitch.mp4
Changes
that's because now you can only open the point by clicking on the red
I had no plan when recording this.