[ENH] ✨ add information in secret link to user #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sathieu
reviewed
Oct 13, 2025
Collaborator
sathieu
left a comment
sathieu
left a comment
There was a problem hiding this comment.
Thanks. I've left a few comments
| ) | ||
| userResource.Spec.SecretFieldNameSecretKey: []byte(secretKey), | ||
| "s3region": []byte(s3Client.GetConfig().Region), | ||
| "s3certificate": []byte(strings.Join(s3Client.GetConfig().CaCertificatesBase64, ",")), |
Comment on lines
-47
to
+49
| S3Config.S3Url, | ||
| S3Config.Endpoint, | ||
| S3Config.Secure, |
Collaborator
There was a problem hiding this comment.
s3 instance has Url, why this change?
Comment on lines
+74
to
+75
| endpoint string, | ||
| isSSL bool, |
Collaborator
There was a problem hiding this comment.
s3 instance has Url, why this change?
| } | ||
| s3Config.Secure = isSSL | ||
| s3Config.Endpoint = endpoint | ||
| s3Logger.Info("region ici : " + s3Config.Region) |
Collaborator
There was a problem hiding this comment.
please remove debugging code.
nvalembois
reviewed
Oct 13, 2025
| ) | ||
| userResource.Spec.SecretFieldNameSecretKey: []byte(secretKey), | ||
| "s3region": []byte(s3Client.GetConfig().Region), | ||
| "s3certificate": []byte(strings.Join(s3Client.GetConfig().CaCertificatesBase64, ",")), |
There was a problem hiding this comment.
Maybe rename field to s3CACertificate.
nvalembois
reviewed
Oct 13, 2025
| userResource.Spec.AccessKey, | ||
| secretKey, | ||
| strings.TrimPrefix(s3Client.GetConfig().Endpoint, "https://"), | ||
| )), |
There was a problem hiding this comment.
Can you add a boolean field s3PathStyleUrl to identify if it's path or virtual-hosted style URL ?
Cf: https://docs.aws.amazon.com/AmazonS3/latest/userguide/VirtualHosting.html#path-style-access
Donatien26
force-pushed
the
fix-108
branch
6 times, most recently
from
14b667c to
3a0ce5f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.