fix empty sirene search bug #287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tfardet
reviewed
Dec 11, 2025
pynsee/sirene/search_sirene.py
Outdated
|
|
||
| df = _clean_data( | ||
| data_final.copy(), | ||
| data_final.copy() if data_final is not None else pd.DataFrame(), |
Collaborator
There was a problem hiding this comment.
I wonder if it would not be clearer/cleaner to have if data_final is None: return pd.DataFrame() before line 255... @tgrandje what do you think?
Collaborator
Author
There was a problem hiding this comment.
I'm not sure of this, but in that case we should return a SireneDataFrame, not a pandas Dataframe. What do you prefer ?
Collaborator
There was a problem hiding this comment.
then let's go for the empty SireneDataFrame before line 255 if you don't mind :)
Collaborator
|
@tgrandje if you have time, could you pull the new head into it and apply the small changes we discussed? |
tfardet
approved these changes
Dec 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #285