Download Captions #244
Download Captions #244
Conversation
|
Sorry if it's a bit of a mess, I tried to combine code that existed on the dev and master branches as well as adding new functionality. Please let me know if I should change anything. |
|
I'll review this and the other pr in bit, thx ❤️ |
Inrixia
left a comment
Inrixia
left a comment
There was a problem hiding this comment.
Few changes needed but mostly good.
I also intend to have ffmpeg mux subtitles same as it does for the album art and other meta. But that is complex enough to warrent a seperate pr (or I'll handle it later) so don't do that here.
Thanks again for the help
src/lib/Video.ts
Outdated
| public readonly description: string; | ||
| public readonly artworkUrl?: string; | ||
| public readonly textTracks?: VideoContent["textTracks"]; | ||
| private _textTracks?: VideoContent["textTracks"]; |
There was a problem hiding this comment.
Just make this public, no need for it to be private with a public getter
There was a problem hiding this comment.
It actually doesn't need a public getter since it is only accessed within Video.ts, so I just made it fully private. This is also true for many other properties of Video which I also made private, but please let me know if you want this reversed.
|
Thanks for the feedback, everything should now be resolved, I just wanted you to double check that it was ok setting all of the properties of Video that aren't accessed elsewhere to private. |
|
I'm going to close this as its implemented on dev, I cant remember why this wasn't merged |
2 participants
Will download captions to the same folder as the video when
downloadCaptionsflag is enabled.If they are available when the video is first downloaded they will download with it. Otherwise, it will keep checking if any of the last
videosToSearchhas any new text tracks added every 5 minutes with the new video fetch.Builds on #237 for issue #226 but adds a feature flag in settings to disable captions and downloads captions even if they are added after video download.