Adds overlay system for the non modal frameless dialogs #173
Conversation
StephenNneji
force-pushed
the
tweak_modal_dialog
branch
2 times, most recently
from
48b3fd1 to
77dd347
Compare
StephenNneji
force-pushed
the
tweak_modal_dialog
branch
from
8f0fed1 to
df934c6
Compare
RabiyaF
left a comment
RabiyaF
left a comment
There was a problem hiding this comment.
The PR looks good 👍🏼 I tested it on Mac and the updated changes provide a much better UX. I tested both the widgets. Everything looks good. There is one small comment.
| self.new_project_action.triggered.connect(lambda: self.presenter.confirmSave(self.showNewProjectWidget)) | ||
|
|
||
| self.open_project_action = QtGui.QAction('&Open Project', self) | ||
| self.open_project_action.setStatusTip('Open an existing project') |
There was a problem hiding this comment.
I see an error originating from line 158 if a certain sequence is followed. Can you verify if it happens on Windows too.
-
Open
SScanSS-2app. -
Click X on the ProjectWidget.
-
Click the open project button.
-
Do not select anything. Just press cancel.
-
I see this Traceback on Mac
I updated openProject as follows to get rid of the error on mac but there might be a better way to do it. Maybe the Open Project icon can be disabled till either a new project is created or an existing project is selected from the ProjectWidget.
There was a problem hiding this comment.
Good catch, the bug was caused by this line
SScanSS-2/sscanss/app/window/view.py
Line 93 in 4d98408
which should be
self.open_project_action.triggered.connect(lambda: self.presenter.confirmSave(self.presenter.openProject))
Should be fixed now
RabiyaF
left a comment
RabiyaF
left a comment
There was a problem hiding this comment.
I tested it on Mac with the latest changes and everything is working as expected.
This will stop these dialogs from getting lost behind other windows or on a second screen