CoDICE lo counters single inst_az_label fix #2527
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greglucas
reviewed
Dec 22, 2025
| ), | ||
| "inst_az_label": xr.DataArray( | ||
| np.arange(inst_az, dtype=np.uint8).astype(str), | ||
| (np.arange(inst_az, dtype=np.uint8) + 1).astype(str), |
Collaborator
There was a problem hiding this comment.
I feel like this might get confusing why the label is different from the values? Do they want the inst_az values being 0-based indices but the labels being 1-based, or instead should they both be 1-based?
Contributor
Author
There was a problem hiding this comment.
The positions themselves are zero based but they are referred to / known as 1 based.. I know that is confusing but I brought this up in the CoDICE tag up this morning and Micael confirmed that this was the desired label.
greglucas
approved these changes
Dec 22, 2025
lacoak21
merged commit 2df8b7f
into
IMAP-Science-Operations-Center:dev
14 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix labels. Request from CoDICE team.