Alert-system: Email setup #2621
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sudip-khanal
changed the title
sudip-khanal
force-pushed
the
feat/add-email-notification-setup-for-alert-system
branch
from
4fd95eb to
5f0786c
Compare
sudip-khanal
requested review from
sandeshit,
susilnem and
thenav56
and removed request for
sandeshit and
susilnem
susilnem
requested changes
Jan 7, 2026
deploy/helm/ifrcgo-helm/values.yaml
Outdated
Comment on lines
286
to
289
| - command: 'alert_notification' | ||
| schedule: '0 */2 * * *' | ||
| - command: 'alert_notification_reply' | ||
| schedule: '0 */4 * * *' |
Member
There was a problem hiding this comment.
Let's not remove the notify_validators from here..
notifications/filter_set.py
Outdated
| region = filters.ModelMultipleChoiceFilter(field_name="regions", queryset=Region.objects.all()) | ||
| alert_source = filters.NumberFilter(field_name="alert_source", label="Alert Source") | ||
| hazard_type = filters.NumberFilter(field_name="hazard_types__type", label="Hazard Type") | ||
| hazard_type = filters.NumberFilter(field_name="hazard_types__name", label="Hazard Type") |
Member
There was a problem hiding this comment.
Suggested change
| hazard_type = filters.NumberFilter(field_name="hazard_types__name", label="Hazard Type") | |
| hazard_type = filters.CharField(field_name="hazard_types__name", label="Hazard Type") |
| ).apply_async() | ||
|
|
||
|
|
||
| @shared_task() |
Member
There was a problem hiding this comment.
We might need a separate queue for these tasks.
…ix notification tests
sudip-khanal
force-pushed
the
feat/add-email-notification-setup-for-alert-system
branch
from
d143643 to
c1f4a3b
Compare
…k and fix notification tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Checklist
Things that should succeed before merging.
Release
If there is a version update, make sure to tag the repository with the latest version.