migrated servo_board_config.h into components and respective individual #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcmarcus
reviewed
Mar 6, 2025
| @@ -155,43 +132,4 @@ HeaterConfig* GET_HEATER_CONFIG(const uint32_t can_id) { | |||
| return NULL; // Return NULL if no match is found | |||
| } | |||
|
|
|||
|
|
|||
| // instance-- is after because zero indexed | |||
| uint32_t GET_SERVO_CAN_ID(const uint32_t* board_uid, uint8_t instance) { | |||
Contributor
There was a problem hiding this comment.
How can you access the individual sensors based on the ID and instance number without these?
Contributor
There was a problem hiding this comment.
I reckon you can also move all of the functions from this file into the other ones, like servo_config.h for instance.
bcmarcus
requested changes
Mar 6, 2025
| @@ -155,43 +132,4 @@ HeaterConfig* GET_HEATER_CONFIG(const uint32_t can_id) { | |||
| return NULL; // Return NULL if no match is found | |||
| } | |||
|
|
|||
|
|
|||
| // instance-- is after because zero indexed | |||
| uint32_t GET_SERVO_CAN_ID(const uint32_t* board_uid, uint8_t instance) { | |||
Contributor
There was a problem hiding this comment.
I reckon you can also move all of the functions from this file into the other ones, like servo_config.h for instance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
component config files