Add comprehensive test coverage for components #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added test suites for main components: - BarChartCard: Tests for rendering, view toggling, filtering, click events, and metric changes - ModelInfoDrawer: Tests for search inputs, suggestions, selection handling, and model rendering - PageHeader: Tests for title, descriptions, and external links - Footer: Tests for GitHub link and icon - FiltersPanel: Tests for team groups, conditions, and toggles Also added window.matchMedia mock to vitest.setup.ts to support components using media queries. All 43 tests pass successfully across 7 test files.
Updated tests to be more maintainable by: - Using dynamic values from test fixtures instead of hardcoded strings - Using DOM queries by role and structure instead of specific text - Making assertions based on relationships rather than specific values This makes tests more resilient to changes in model names, labels, and other data values that may evolve over time.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added test suites for main components:
Also added window.matchMedia mock to vitest.setup.ts to support components using media queries.
All 43 tests pass successfully across 7 test files.