Skip to content

Conversation

@ldfajardo10-tech
Copy link

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Implement & Interpret Exercises:

  • Contains
  • Lookup
  • Tally
  • QueryStrings
  • Invert

I forget to create a new branch for the interpret/invert exercise so I pushed in this branch.

@fgsumer
Copy link

fgsumer commented Jan 1, 2026

@ldfajardo10-tech

Overall, nice work.

There are some changes needed.
Can you update your code based on the feedback below, please?

  • For tally(), createLookup() and contains() there are just console.log()’s. These are not formal tests. You should write tests using a test framework like test(...) and expect(...)

  • In queryString.js, queryParams is used but not declared

  • In invert.js, toBe() is used to compare references. It should be toEqual().

  • In invert.js, a and b are not defined in test scope. This is how the test look like :

     test("inverts object with numeric values", () => {
        expect(invert({ a: 1, b: 2 })).toEqual({ "1": "a", "2": "b" });
     });

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants