Skip to content

Conversation

@gavlyukovskiy
Copy link
Collaborator

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR configures proper proxy header passing to OpenAPI by replacing the custom Swagger reverse proxy configuration with Spring Boot's built-in forwarded headers strategy and nginx proxy headers.

Key changes:

  • Replaces custom SwaggerBehindReverseProxyConfig with Spring's native server.forward-headers-strategy=framework
  • Adds X-Forwarded-Prefix header in nginx configuration to properly handle the /api path prefix
  • Removes the OPEN_API_SUFFIX environment variable and related SpringDoc custom URL configurations

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
deployment/nginx.conf Adds X-Forwarded-Prefix header to pass /api prefix to backend
deployment/docker-compose.yaml Removes OPEN_API_SUFFIX env var, changes JVM_TOOL_OPTS to JAVA_OPTS, comments out watchtower service
deployment/README.md Adds duplicated Operations section with same commands
backend/src/main/resources/application.properties Enables Spring's forwarded headers strategy, removes custom OpenAPI suffix configuration
backend/src/main/java/net/hackyourfuture/coursehub/SwaggerBehindReverseProxyConfig.java Removes entire custom Swagger reverse proxy configuration class
backend/src/main/java/net/hackyourfuture/coursehub/CourseHubApplication.java Removes trailing blank line
.github/workflows/on-release-tag.yml Sets working directory for frontend build job

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@gavlyukovskiy gavlyukovskiy force-pushed the fix-open-api branch 2 times, most recently from aa59173 to d29e99f Compare October 20, 2025 19:55
@gavlyukovskiy gavlyukovskiy merged commit df0ef54 into main Oct 20, 2025
2 checks passed
@Breus Breus deleted the fix-open-api branch October 21, 2025 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants