Skip to content

Conversation

@Dmytro-Doronin
Copy link

No description provided.

@latifniz
Copy link

Hi Dmytro,

Good work on finishing all the exercises! Here is my feedback:

What you did well

ex1 & ex2: clear functions, all tests passed.

ex3: good use of a helper function, makes the code easier to read.

Arrays and return strings are written well.

Removed most TODO comments, code looks clean.

What can be improved

ex4 & ex5: functions work, but think about what happens if you call them without giving an item. Make sure return values are always the same type.

ex6: works fine. You can use .toFixed(2) to make the total price show 2 decimals.

ex7: good use of map and destructuring. Use clear variable names to make the code easier to follow.

General advice

Remove console.log after testing.

Keep using helper functions like selectRandomly, it’s a good habit.

Don’t worry if code looks long, clarity is more important right now.

Overall, nice progress 👏 You show good understanding of functions, arrays, and objects. Keep practicing and it will get easier.

— latif

@Dmytro-Doronin
Copy link
Author

Thank you for feedback! I’ve added fix to ex-6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants