Skip to content

Conversation

@jreadey
Copy link
Member

@jreadey jreadey commented Dec 1, 2025

container restarts can mix up the DN container ordering. This change should address that.


Important

Assigns container rank by registration order and updates logging in headnode.py, azureBlobClient.py, and fileClient.py.

  • Behavior:
    • Assigns container rank based on registration order in register() in headnode.py.
    • Maintains active_sn_ids and active_dn_ids lists to track active nodes.
    • Removes unhealthy nodes from active lists to make room for new registrations.
  • Functions:
    • Adds getNodeUrls() in headnode.py to generate node URLs from active node IDs.
    • Modifies isClusterReady() in headnode.py to use active node lists for readiness checks.
  • Logging:
    • Changes log level from warn to info for not found messages in get_object() in azureBlobClient.py and fileClient.py.

This description was created by Ellipsis for b96dd65. You can customize this summary. It will automatically update as commits are pushed.

hsds/headnode.py Outdated
# all the slots are filled, see if there is any unhealthy node
# and remove that
for i in range(len(active_list)):
node_id = active_list[i]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid reusing the variable node_id inside the loops; it gets overwritten when iterating the active list. Use a distinct name (e.g. existing_node_id) for clarity.

# all the slots are filled, see if there is any unhealthy node
# and remove that
for i in range(len(active_list)):
id = active_list[i]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid using id which shadows the built-in function. Use a more descriptive name like node_id for clarity.

@jreadey jreadey merged commit 824d008 into master Dec 1, 2025
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants