Autotools fixes #210
Draft
Autotools fixes #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The proposed changes need more discussion.
ajelenak
requested review from
bmribler,
byrnHDF,
fortnern,
jhendersonHDF and
lrknox
as code owners
ajelenak
requested review from
brtnfld,
glennsong09 and
mattjala
as code owners
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Makefile.am
Outdated
| LZ4 = LZ4 | ||
| endif | ||
|
|
||
| # Does the user want to build lz4? |
There was a problem hiding this comment.
Conditional block comments are misleading. Lines 20 and 25 state 'Does the user want to build lz4?' for JPEG and LZF. Update these comments to correctly refer to JPEG and LZF.
Suggested change
| # Does the user want to build lz4? | |
| # Does the user want to build JPEG? |
Closed
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is PR #202 without the changes in the LZ4 plugin because those changed the plugin's
cd_values[].Important
Update autotools configurations, plugin paths, and add test scripts for BZIP2, JPEG, LZ4, and LZF plugins.
AC_PREREQto 2.71 inBZIP2/configure.ac,JPEG/configure.ac,LZ4/configure.ac, andLZF/configure.ac.AC_INITandAC_CONFIG_HEADERSsyntax inBZIP2/configure.ac,JPEG/configure.ac,LZ4/configure.ac, andLZF/configure.ac.HDF5_PLUGIN_DIRtoHDF5_PLUGIN_PATHinBZIP2/configure.ac,JPEG/configure.ac,LZ4/configure.ac, andLZF/configure.ac.plugindirto@HDF5_PLUGIN_PATH@inBZIP2/src/Makefile.am,JPEG/src/Makefile.am,LZ4/src/Makefile.am, andLZF/src/Makefile.am.run_tests.shtoJPEG/example/Makefile.am,LZ4/example/Makefile.am, andLZF/example/Makefile.am.check_PROGRAMSandTESTSinJPEG/example/Makefile.am,LZ4/example/Makefile.am, andLZF/example/Makefile.amto include test scripts.libtool.m4andltversion.m4inBZIP2/m4to newer versions.JPEG_QUALITYto 50 inJPEG/example/h5ex_d_jpeg.cand update related test files.This description was created by
for da1fab3. You can customize this summary. It will automatically update as commits are pushed.