Switch version setting to use VERSION.txt and CMake configure in bin/… #6100
Conversation
…update-version.sh, and update version to 2.1.0.
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
| if (HDF5_PROVIDES_JNI AND HDF5_Java_FOUND) | ||
| set (H5${EXTNAME}_JAVA_LIBRARY ${HDF5_JAVA_LIBRARY}) | ||
| set (H5${EXTNAME}_JAVA_LIBRARIES ${HDF5_JAVA_LIBRARY}) | ||
| message (STATUS "HDF5 lib:${H5${EXTNAME}_JAVA_LIBRARY} jars:${HDF5_JAVA_INCLUDE_DIRS}}") |
There was a problem hiding this comment.
Typographical error: In the message on this line, there is an extra closing brace after ${HDF5_JAVA_INCLUDE_DIRS}, i.e. jars:${HDF5_JAVA_INCLUDE_DIRS}}. It should probably be jars:${HDF5_JAVA_INCLUDE_DIRS}.
| message (STATUS "HDF5 lib:${H5${EXTNAME}_JAVA_LIBRARY} jars:${HDF5_JAVA_INCLUDE_DIRS}}") | |
| message (STATUS "HDF5 lib:${H5${EXTNAME}_JAVA_LIBRARY} jars:${HDF5_JAVA_INCLUDE_DIRS}}") |
| } | ||
| catch (Throwable err) { | ||
| err.printStackTrace(); | ||
| fail("TestH5Pfapl.createH5file: " + err); |
There was a problem hiding this comment.
Typographical error: the error message text TestH5Pfapl.createH5file: appears to have a typo. It might be intended to be TestH5.createH5file:.
| fail("TestH5Pfapl.createH5file: " + err); | |
| fail("TestH5.createH5file: " + err); |
| * | ||
| * The most common cause of this failure is that an application was | ||
| * compiled with one version of HDF5 and is dynamically linked with a | ||
| * different version different version. |
There was a problem hiding this comment.
Typo: In the H5check_version documentation, the phrase "different version" is duplicated. Consider revising the sentence to remove the duplicate, e.g., "... and is dynamically linked with a different version."
| * different version different version. | |
| * different version. |
| set (CTEST_SOURCE_VERSION "2.0.1") | ||
| set (CTEST_SOURCE_VERSEXT "") | ||
| set (CTEST_SOURCE_VERSION "2.1.0") | ||
| if ("" STREQUAL "") |
There was a problem hiding this comment.
Something not quite right here!
| set (HDF5_VERSION "2.0.1") | ||
| set (HDF5_VERSEXT "") | ||
| set (HDF5_VERSION "2.1.0") | ||
| if ("" STREQUAL "") |
There was a problem hiding this comment.
Again, looks like something is not getting configured correctly
2 participants
…update-version.sh, and update version to 2.1.0.
Important
Switch version setting to use
VERSION.txtand CMake configure, updating version to 2.1.0 and adding scripts for version management.VERSION.txtand CMake configure inCMakeLists.txt.README.md,CHANGELOG.md, andH5public.h.update-version.shandupdate-version.batfor version file regeneration.HDF5Version.cmakefor reading version fromVERSION.txt.CMakeLists.txt.TestH5.java.inandTestH5.javafor Java tests with version placeholders.CHANGELOG.mdandREADME.mdto reflect version 2.1.0.This description was created by
for b0c7821. You can customize this summary. It will automatically update as commits are pushed.