-
Notifications
You must be signed in to change notification settings - Fork 54
feat[cartesian]: Allow OpenMP to be deactivated #2435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat[cartesian]: Allow OpenMP to be deactivated #2435
Conversation
|
@edopao This PR allows us to deactivate threading on the It's on an env var: Can you help out modify the CI config and do a dry run to see if it helps? |
|
I have tried setting this variable on the branch dace_ci_cartesian, but the CI still fails: I can see from the log that the variable is set: I have also tried with It seems to me that after the first error of this kind, the pytest worker cannot recover and all tests on this pytest worker fail. Could this suggest that some memory is corrupted / in wrong state? |
|
What is strange to me is that this problem only happens with Python "highest" strategy for dependency resolution, so there might be some newer python package that somehow leads to different generated code. I will try locally on my Mac. |
|
I don't see this problem locally on my Mac, using OpenMP from brew installation as in the CI job. I will now try to use a newer MacOS image in the CI, which is the next candidate release (macos-26). |
Unfortunately, it still fails on macos-26. Next test, I could switch to gcc, installed through brew. |
So this was my first hunch, too but the code are exactly the same between those versions. I am on Linux and can't reproduce either |
I still see the same issue using gcc instead of default clang compiler: |
|
If this is truly a number of threads problem coming from a combination of newer packages + interpreter + our code, can we split the tests?
For our team, the fact that MacOS doesn't know how to threads is pretty low in the stack of issues... |
Description
Move maps to
SequentialwhenGT4PY_CARTESIAN_DEACTIVATE_THREADING=Truefordace:Xstencil backendsRequirements