Skip to content

feat[dace][next]: Added Reduction Node Capabilities to the Rerouting Utility #2215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
philip-paul-mueller merged 8 commits into from
Aug 13, 2025
Merged

feat[dace][next]: Added Reduction Node Capabilities to the Rerouting Utility #2215

philip-paul-mueller merged 8 commits into from
Aug 13, 2025

Conversation

@philip-paul-mueller
Copy link
Contributor

@philip-paul-mueller philip-paul-mueller commented Aug 12, 2025 •
edited
Loading

Before the rerouting utility did not handle library nodes.
This PR adds the capability to handle reduction nodes, not library nodes in general.
It solves the error observed in ICON4Py PR#822.

@philip-paul-mueller
Copy link
Contributor Author

philip-paul-mueller commented Aug 13, 2025

This PR fixes the issue observed in the failing tests of ICON4Py PR#822.
The reroute functionality was before tested indirectly, through other transformations, since it was an integral part.
However, I realized when I implemented the case for the reduction library node, that a proper specific testing is missing, so I started on in PR#2216.
The only reason why they are separated is for scheduling reasons.

@philip-paul-mueller philip-paul-mueller changed the title feat[dace][next]: New Case For CopyChainRemover feat[dace][next]: Added Reduction Node Capabilities to the Rerouting Utility Aug 13, 2025
@philip-paul-mueller
Copy link
Contributor Author

philip-paul-mueller commented Aug 13, 2025

Note that this PR is highly related to PR#2216, which adds unit tests explicitly for the rerouting functionality.
It is, however, independent form it.

@philip-paul-mueller philip-paul-mueller marked this pull request as ready for review August 13, 2025 07:04
havogt
havogt approved these changes Aug 13, 2025
View reviewed changes
Copy link
Contributor

@havogt havogt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@philip-paul-mueller philip-paul-mueller merged commit 906c1aa into GridTools:main Aug 13, 2025
23 checks passed
@philip-paul-mueller philip-paul-mueller mentioned this pull request Aug 14, 2025
Merged
@philip-paul-mueller philip-paul-mueller deleted the new_case_in_copy_chain_remover branch October 9, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@havogt havogt havogt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@philip-paul-mueller @havogt