Skip to content

Conversation

@GregHib
Copy link
Owner

@GregHib GregHib commented Jan 10, 2026

Fixes a bunch of bugs, a lot combat related. Reworks combat movement, aggression, attack ranges and retreating mechanics.
Closes #815, #812, #813, #824, #811, #809, #804, #805

@github-actions
Copy link
Contributor

github-actions bot commented Jan 10, 2026

Qodana Community for JVM

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@codecov
Copy link

codecov bot commented Jan 10, 2026

Codecov Report

❌ Patch coverage is 25.16556% with 113 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.49%. Comparing base (f6346e6) to head (c6ccf75).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ine/entity/character/mode/combat/CombatMovement.kt 0.00% 25 Missing ⚠️
...voidps/engine/map/collision/GameObjectCollision.kt 4.00% 23 Missing and 1 partial ⚠️
...egs/voidps/engine/entity/character/mode/Retreat.kt 0.00% 18 Missing ⚠️
...ter/mode/move/target/NPCCharacterTargetStrategy.kt 15.00% 17 Missing ⚠️
...gs/voidps/engine/map/collision/CollisionDecoder.kt 33.33% 6 Missing and 2 partials ⚠️
...voidps/engine/data/definition/PrayerDefinitions.kt 0.00% 4 Missing ⚠️
...idps/engine/entity/character/player/skill/Skill.kt 0.00% 4 Missing ⚠️
...voidps/engine/data/definition/CombatDefinitions.kt 0.00% 3 Missing ⚠️
...idps/engine/entity/character/mode/move/Movement.kt 70.00% 1 Missing and 2 partials ⚠️
...voidps/engine/entity/character/npc/hunt/Hunting.kt 0.00% 2 Missing ⚠️
... and 5 more
Additional details and impacted files
Files with missing lines Coverage Δ
...gs/voidps/engine/data/config/HuntModeDefinition.kt 0.00% <ø> (ø)
...s/voidps/engine/data/definition/ItemDefinitions.kt 28.88% <ø> (ø)
.../gregs/voidps/engine/entity/character/mode/Face.kt 0.00% <ø> (ø)
.../engine/entity/character/mode/interact/Interact.kt 55.43% <100.00%> (ø)
...e/entity/character/mode/interact/InteractOption.kt 100.00% <100.00%> (ø)
.../character/mode/interact/NPCOnFloorItemInteract.kt 100.00% <100.00%> (ø)
...entity/character/mode/interact/NPCOnNPCInteract.kt 100.00% <100.00%> (ø)
...ity/character/mode/interact/NPCOnObjectInteract.kt 75.00% <100.00%> (ø)
...ity/character/mode/interact/NPCOnPlayerInteract.kt 100.00% <100.00%> (ø)
...aracter/mode/interact/PlayerOnFloorItemInteract.kt 92.85% <100.00%> (ø)
... and 18 more

... and 11 files with indirect coverage changes

@@             Coverage Diff              @@
##               main     #826      +/-   ##
============================================
- Coverage     37.50%   37.49%   -0.01%     
- Complexity     7385     7397      +12     
============================================
  Files          1480     1482       +2     
  Lines         58694    58779      +85     
  Branches      14681    14699      +18     
============================================
+ Hits          22014    22042      +28     
- Misses        31782    31824      +42     
- Partials       4898     4913      +15     
Components Coverage Δ
Content 34.82% <ø> (-0.02%) ⬇️
Engine 43.13% <25.16%> (+0.02%) ⬆️
Network 60.93% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@GregHib GregHib changed the title Combat and collision bug fixes Combat bug fixes and mechanic reworks Jan 10, 2026
@GregHib GregHib merged commit a44256c into main Jan 10, 2026
5 checks passed
@GregHib GregHib deleted the bug-fixes branch January 10, 2026 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Farming patch collision is broken

2 participants