Skip to content

Conversation

@abhijeetkjha-google
Copy link
Contributor

compute: adding support for generating cloud router plural datasources 

The data source to list compute routers is missing, though corresponding resource and get method do exist.

@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@malhotrasagar2212, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 280 insertions(+))
google-beta provider: Diff ( 4 files changed, 280 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1319
Passed tests: 1233
Skipped tests: 84
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFutureReservation_sharedFutureReservationExample
  • TestAccDataSourceGoogleComputeRouters_basic

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleComputeRouters_basic [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 502 insertions(+))
google-beta provider: Diff ( 4 files changed, 502 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1319
Passed tests: 1233
Skipped tests: 84
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFutureReservation_sharedFutureReservationExample
  • TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants