Skip to content

Conversation

@sushilchaskar28
Copy link
Contributor

@sushilchaskar28 sushilchaskar28 commented Dec 23, 2025

dataplex: added `one_time` field to `google_dataplex_datascan` resource

@github-actions github-actions bot requested a review from c2thorn December 23, 2025 22:51
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 544 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 544 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 38 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 75
Passed tests: 57
Skipped tests: 0
Affected tests: 18

Click here to see the affected service packages
  • dataplex

Action taken

Found 18 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexDataQualityRules
  • TestAccDataplexDatascanDataplexDatascanFullQuality_update
  • TestAccDataplexDatascanIamBindingGenerated
  • TestAccDataplexDatascanIamMemberGenerated
  • TestAccDataplexDatascanIamPolicyGenerated
  • TestAccDataplexDatascan_dataplexDatascanBasicDiscoveryExample
  • TestAccDataplexDatascan_dataplexDatascanBasicProfileExample
  • TestAccDataplexDatascan_dataplexDatascanBasicQualityExample
  • TestAccDataplexDatascan_dataplexDatascanDocumentationExample
  • TestAccDataplexDatascan_dataplexDatascanFullDiscoveryExample
  • TestAccDataplexDatascan_dataplexDatascanFullProfileTestExample
  • TestAccDataplexDatascan_dataplexDatascanFullProfile_update
  • TestAccDataplexDatascan_dataplexDatascanFullQualityTestExample
  • TestAccDataplexDatascan_dataplexDatascanOnetimeDiscoveryExample
  • TestAccDataplexDatascan_dataplexDatascanOnetimeDocumentationExample
  • TestAccDataplexDatascan_dataplexDatascanOnetimeProfileExample
  • TestAccDataplexDatascan_dataplexDatascanOnetimeQualityExample
  • TestAccDataplexEntry_dataplexEntryBigqueryTableExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataplexDataQualityRules [Debug log]
TestAccDataplexDatascanDataplexDatascanFullQuality_update [Debug log]
TestAccDataplexDatascanIamBindingGenerated [Debug log]
TestAccDataplexDatascanIamMemberGenerated [Debug log]
TestAccDataplexDatascanIamPolicyGenerated [Debug log]
TestAccDataplexDatascan_dataplexDatascanBasicDiscoveryExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanBasicProfileExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanBasicQualityExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanDocumentationExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanFullDiscoveryExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanFullProfileTestExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanFullProfile_update [Debug log]
TestAccDataplexDatascan_dataplexDatascanFullQualityTestExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanOnetimeDiscoveryExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanOnetimeDocumentationExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanOnetimeProfileExample [Debug log]
TestAccDataplexDatascan_dataplexDatascanOnetimeQualityExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccDataplexEntry_dataplexEntryBigqueryTableExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

sushilchaskar28 referenced this pull request Dec 24, 2025
Co-authored-by: Marek Lipert <lipertmj@google.com>
@sushilchaskar28
Copy link
Contributor Author

TestAccDataplexEntry_dataplexEntryBigqueryTableExample test failure is unrelated to the cl. Added a comment in 1e50597#r173423825

sushilchaskar28 added a commit to sushilchaskar28/magic-modules that referenced this pull request Dec 24, 2025
This is causing TestAccDataplexEntry_dataplexEntryBigqueryTableExample test failure in GoogleCloudPlatform#16024
@sushilchaskar28
Copy link
Contributor Author

raised separate #16026 to fix the entry test

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 544 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 544 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 38 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 75
Passed tests: 74
Skipped tests: 0
Affected tests: 1

Click here to see the affected service packages
  • dataplex

Action taken

Found 1 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccDataplexEntry_dataplexEntryBigqueryTableExample

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccDataplexEntry_dataplexEntryBigqueryTableExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants