Skip to content

Conversation

@karolgorc
Copy link
Contributor

Hi
I have no environment to test this so just wanted to ask how do you test interconnects?
All im looking for right now is to see the errors these fields return on a correct environment. Im also trying to get in contact with the maintainers of these fields on Google's side to see if they are essential to any configurations.

Release Note Template for Downstream PRs (will be copied)

See Write release notes for guidance.

Support for `L2_DEDICATED` interconnect type on `compute_interconnect_attachment`

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Dec 17, 2025
@github-actions github-actions bot requested a review from roaks3 December 17, 2025 14:58
@github-actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

Googlers: For automatic test runs see go/terraform-auto-test-runs.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

Copy link
Contributor

@roaks3 roaks3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to tests out (although IP addresses might need to change). Running now...

@modular-magician modular-magician added service/compute-interconnect and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Dec 17, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 311 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 311 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 87 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 131 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1318
Passed tests: 1233
Skipped tests: 83
Affected tests: 2

Click here to see the affected service packages
  • compute

Action taken

Found 2 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFutureReservation_sharedFutureReservationExample
  • TestAccComputeInterconnectAttachment_interconnectAttachmentL2Example

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentL2Example [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@zli82016
Copy link
Member

/gcbrun

@modular-magician modular-magician added awaiting-approval Pull requests that need reviewer's approval to run presubmit tests and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Dec 23, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 311 insertions(+), 3 deletions(-))
google-beta provider: Diff ( 4 files changed, 311 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 87 insertions(+))
Open in Cloud Shell: Diff ( 4 files changed, 131 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 1319
Passed tests: 1232
Skipped tests: 84
Affected tests: 3

Click here to see the affected service packages
  • compute

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeFutureReservation_sharedFutureReservationExample
  • TestAccComputeInterconnectAttachment_interconnectAttachmentL2Example
  • TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionBackendService_regionBackendServiceHaPolicyManualLeader_update [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccComputeFutureReservation_sharedFutureReservationExample [Error message] [Debug log]
TestAccComputeInterconnectAttachment_interconnectAttachmentL2Example [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants