fix(firestore-semantic-search): add enforceAppCheck to queryIndex function #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
There was a problem hiding this comment.
Pull Request Overview
This PR enforces App Check on the queryIndex function and updates the extension version.
- Wraps
queryIndexwithrunWith({ enforceAppCheck: true }) - Bumps extension version to 0.1.10 in
extension.yaml - Adds a changelog entry for version 0.1.10
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| functions/src/index.ts | Added runWith({ enforceAppCheck: true }) to queryIndex |
| extension.yaml | Updated version to 0.1.10 |
| CHANGELOG.md | Documented the App Check fix under version 0.1.10 |
Collaborator
|
Maybe we want to make this optional? Could be a breaking change atm? |
cabljac
reviewed
Sep 1, 2025
| label: Enforce App Check | ||
| description: >- | ||
| Enforce App Check for the extension's functions. | ||
| type: boolean |
Collaborator
There was a problem hiding this comment.
is type: boolean supported?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #686