Skip to content

Added the tenant and product as prefix to the OIDC subject #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ostangenberg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added the tenant and product as prefix to the OIDC subject #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions npm/src/controller/oauth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1330,16 +1330,24 @@ export class OAuthController implements IOAuthController {
};
const signingKey = await loadJWSPrivateKey(jwtSigningKeys.private, jwsAlg!);
const kid = await computeKid(jwtSigningKeys.public, jwsAlg!);
let subjectPrefix = ""
if(codeVal.requested?.tenant) {
subjectPrefix += `${codeVal.requested.tenant}|`;
}
if(codeVal.requested?.product) {
subjectPrefix += `${codeVal.requested.product}|`;
}
const subject_id = subjectPrefix + codeVal.profile.claims.id;
const id_token = await new jose.SignJWT(claims)
.setProtectedHeader({ alg: jwsAlg!, kid })
.setIssuedAt()
.setIssuer(this.opts.externalUrl)
.setSubject(codeVal.profile.claims.id)
.setSubject(subject_id)
.setAudience(tokenVal.requested.client_id)
.setExpirationTime(`${this.opts.db.ttl}s`) // identity token only really needs to be valid long enough for it to be verified by the client application.
.sign(signingKey);
tokenVal.id_token = id_token;
tokenVal.claims.sub = codeVal.profile.claims.id;
tokenVal.claims.sub = subject_id;
}

const { hexKey, encVal } = encrypt(tokenVal);
Expand Down