Skip to content

Conversation

@undefined06855
Copy link

@undefined06855 undefined06855 commented Aug 27, 2025

Adds globed::room::

  • isInGlobal
  • getRoomData
  • joinRoom

Adds some events

  • RoomJoinEvent
  • RoomUpdateEvent
  • RoomLeaveEvent
  • NetworkManagerConnectedEvent
  • NetworkManagerDisonnectedEvent

and updates geode version in mod.json

@undefined06855 undefined06855 marked this pull request as ready for review August 28, 2025 16:04
@undefined06855
Copy link
Author

wait i forgot something hold on

@undefined06855 undefined06855 marked this pull request as draft August 28, 2025 16:17
@undefined06855
Copy link
Author

actually it doesnt matter

@undefined06855 undefined06855 marked this pull request as ready for review August 28, 2025 16:20
@undefined06855
Copy link
Author

actually it does matter

@undefined06855 undefined06855 marked this pull request as draft August 31, 2025 19:22
@dankmeme01 dankmeme01 requested a review from Copilot August 31, 2025 19:23
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive room-related APIs to the Globed mod, enabling developers to interact with room functionality through a public API. The changes introduce room state checking, data retrieval, and joining capabilities along with corresponding event notifications.

Key changes:

  • Adds new room APIs (isInGlobal, getRoomData, joinRoom) in the globed::room namespace
  • Implements room-related events (RoomJoinEvent, RoomUpdateEvent, RoomLeaveEvent) and network manager events
  • Updates Geode version requirement from 4.6.1 to 4.8.0

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
include/room.hpp Defines RoomData struct, room events, and public room API functions
include/net.hpp Adds NetworkManagerConnectedEvent and NetworkManagerDisconnectedEvent classes
include/globed.hpp Includes the new room.hpp header
include/_internal.hpp Adds internal type enums for room API endpoints
src/globed/event_dispatcher.cpp Implements room API functionality and event handling logic
src/managers/room.cpp Updates room manager to emit events on room state changes
src/net/manager.cpp Adds network manager connected/disconnected event emission
src/ui/menu/room/room_settings_popup.cpp Comments out redundant room info setting call
mod.json Updates Geode version requirement

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant