-
Notifications
You must be signed in to change notification settings - Fork 59
Add room APIs #324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add room APIs #324
Conversation
|
wait i forgot something hold on |
|
actually it doesnt matter |
|
actually it does matter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds comprehensive room-related APIs to the Globed mod, enabling developers to interact with room functionality through a public API. The changes introduce room state checking, data retrieval, and joining capabilities along with corresponding event notifications.
Key changes:
- Adds new room APIs (
isInGlobal,getRoomData,joinRoom) in theglobed::roomnamespace - Implements room-related events (
RoomJoinEvent,RoomUpdateEvent,RoomLeaveEvent) and network manager events - Updates Geode version requirement from 4.6.1 to 4.8.0
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| include/room.hpp | Defines RoomData struct, room events, and public room API functions |
| include/net.hpp | Adds NetworkManagerConnectedEvent and NetworkManagerDisconnectedEvent classes |
| include/globed.hpp | Includes the new room.hpp header |
| include/_internal.hpp | Adds internal type enums for room API endpoints |
| src/globed/event_dispatcher.cpp | Implements room API functionality and event handling logic |
| src/managers/room.cpp | Updates room manager to emit events on room state changes |
| src/net/manager.cpp | Adds network manager connected/disconnected event emission |
| src/ui/menu/room/room_settings_popup.cpp | Comments out redundant room info setting call |
| mod.json | Updates Geode version requirement |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Adds globed::room::
Adds some events
and updates geode version in mod.json