feat(mcp): Fix 301 redirect #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:APPAI-154
https://linear.app/gitguardian/issue/APPAI-154/toolerror-error-calling-tool-create-code-fix-request-failed-to-create
Root Cause
The httpx.AsyncClient() by default has follow_redirects=False. When the GitGuardian API at https://api.staging.gitguardian.tech/v1/code-fix-requests returns a 301 redirect (to add a trailing slash), httpx raises an error instead of following it.
Fix
Added follow_redirects=True to all httpx.AsyncClient() instantiations:
All 42 tests pass. The MCP server will now properly follow HTTP redirects from the API.