Skip to content

[CHA-0] changed filter conditions to filter #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nijeesh-stream merged 4 commits into from
Nov 19, 2025
Merged

[CHA-0] changed filter conditions to filter #217

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dc4d235
changed filter conditions to filter
nijeesh-stream Nov 19, 2025
aa33cf9
updated testcases
nijeesh-stream Nov 19, 2025
6e63c44
removed unwanted changes
nijeesh-stream Nov 19, 2025
1c941f6
fixed linting
nijeesh-stream Nov 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/main/java/io/getstream/chat/java/models/Reminder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ public static class ReminderQueryRequestData {

@Singular
@Nullable
@JsonProperty("filter_conditions")
@JsonProperty("filter")
private Map<String, Object> filterConditions;

@Singular
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/io/getstream/chat/java/ReminderTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,8 @@ void whenQueryingRemindersWithFilterConditions_thenNoException() {

// Verify the query returned results
Assertions.assertNotNull(reminders);
// Note: The API might not return any reminders if they were deleted or not indexed yet
// So we don't assert that the list is not empty
Assertions.assertEquals(1, reminders.size());
Assertions.assertEquals(message.getId(), reminders.get(0).getMessageId());

// Check for pagination fields
Assertions.assertDoesNotThrow(
Expand Down