Skip to content

fix: fix message count test after ff removal #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adityaalifn merged 3 commits into from
Oct 22, 2025
Merged

fix: fix message count test after ff removal #212

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0c1e54c
fix: fix message count test after ff removal
javierdfm Oct 22, 2025
828bcc4
Merge branch 'main' into cha-1300-fix-test-message-count
javierdfm Oct 22, 2025
94d6707
fix: spotlessapply
javierdfm Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/test/java/io/getstream/chat/java/MessageCountTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import io.getstream.chat.java.models.Channel;
import io.getstream.chat.java.models.Channel.ChannelGetResponse;
import io.getstream.chat.java.models.Channel.ChannelRequestObject;
import io.getstream.chat.java.models.ChannelType;
import io.getstream.chat.java.models.Message;
import io.getstream.chat.java.models.Message.MessageRequestObject;
import java.util.HashMap;
Expand All @@ -17,11 +18,15 @@ public class MessageCountTest extends BasicTest {
@DisplayName("Message count is present when feature enabled")
@Test
void whenCountMessagesEnabled_thenMessagesCount() {
// Create a fresh channel with default configuration (count_messages enabled by default)
// Enable count_messages on the built-in "messaging" channel type
Assertions.assertDoesNotThrow(
() -> ChannelType.update("messaging").countMessages(true).request());
pause();

ChannelGetResponse channelGetResponse =
Assertions.assertDoesNotThrow(
() ->
Channel.getOrCreate("team", RandomStringUtils.randomAlphabetic(12))
Channel.getOrCreate("messaging", RandomStringUtils.randomAlphabetic(12))
.data(
ChannelRequestObject.builder()
.createdBy(testUserRequestObject)
Expand All @@ -47,6 +52,9 @@ void whenCountMessagesEnabled_thenMessagesCount() {
Assertions.assertTrue(
refreshed.getChannel().getMessageCount() == 1,
"messages_count should be 1 when count_messages is enabled");

// Cleanup: delete channel created for this test
Assertions.assertDoesNotThrow(() -> Channel.delete(type, id).request());
}

@DisplayName("Message count is not returned when feature disabled")
Expand Down Expand Up @@ -87,5 +95,8 @@ void whenCountMessagesDisabled_thenNoMessageCountPresent() {
Integer messagesCount = refreshed.getChannel().getMessageCount();
Assertions.assertNull(
messagesCount, "messages_count should not be present when count_messages is disabled");

// Cleanup: delete channel created for this test
Assertions.assertDoesNotThrow(() -> Channel.delete(type, id).request());
}
}