Skip to content

fix: restore @JsonAnyGetter functionality for additionalFields serialization #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
adityaalifn wants to merge 2 commits into from
Closed

fix: restore @JsonAnyGetter functionality for additionalFields serialization #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4eae656
fix: restore @JsonAnyGetter functionality for additionalFields serial…
adityaalifn Oct 22, 2025
f9a5880
Merge branch 'main' into fix/jackson-anygetter-visibility
adityaalifn Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/io/getstream/chat/java/services/framework/DefaultClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,8 +104,10 @@ private Retrofit buildRetrofitClient() {
return chain.proceed(request);
});
final ObjectMapper mapper = new ObjectMapper();
// Use field-based serialization but respect @JsonProperty and @JsonAnyGetter annotations
mapper.setVisibility(PropertyAccessor.ALL, JsonAutoDetect.Visibility.NONE);
// Use field-based access for both serialization and deserialization
// Disable getter auto-detection to avoid issues, but keep setters for deserialization
mapper.setVisibility(PropertyAccessor.GETTER, JsonAutoDetect.Visibility.NONE);
mapper.setVisibility(PropertyAccessor.SETTER, JsonAutoDetect.Visibility.ANY);
mapper.setVisibility(PropertyAccessor.FIELD, JsonAutoDetect.Visibility.ANY);
mapper.configure(
DeserializationFeature.FAIL_ON_UNKNOWN_PROPERTIES,
Expand Down
3 changes: 2 additions & 1 deletion src/test/java/io/getstream/chat/java/AppTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,8 @@ void whenUpdatingAppSettingsWithPendingMessageEventHook_thenNoException() throws
void whenEncodingAppConfig_thenNoNullFields() {
var appConfig = App.update().internalBuild();
final ObjectMapper mapper = new ObjectMapper();
mapper.setVisibility(PropertyAccessor.ALL, JsonAutoDetect.Visibility.NONE);
mapper.setVisibility(PropertyAccessor.GETTER, JsonAutoDetect.Visibility.NONE);
mapper.setVisibility(PropertyAccessor.SETTER, JsonAutoDetect.Visibility.ANY);
mapper.setVisibility(PropertyAccessor.FIELD, JsonAutoDetect.Visibility.ANY);

String json = Assertions.assertDoesNotThrow(() -> mapper.writeValueAsString(appConfig));
Expand Down
Loading