Skip to content

Conversation

@giacomolamanna
Copy link

Summary

This pull request fixes a parsing issue in the IfcPropertyTableValue.parse method.

Problem

When .ifc files include value lists like (IFCLABEL('X')), the GeometryGym parser did not handle them correctly because the parentheses were not removed before calling SplitLineFields.

As a result, DefiningValues and DefinedValues were not being populated.

Solution

This fix adds a check that strips the outer parentheses from the string (if present) before parsing. This allows correct handling of value lists.

Impact

The change affects only IfcPropertyTableValue.parse() and is backward-compatible. All other classes are untouched.

Test Case

This issue was identified while parsing the official buildingSMART IDS test case:

📂 fail-any_matching_value_in_a_table_property_will_pass_3_3.ifc
📎 Test file link on GitHub

With this fix, DefiningValues and DefinedValues in the IfcPropertyTableValue are correctly populated.

…lue lists

DefiningValues and DefinedValues were not parsed correctly when surrounded by parentheses like (IFCLABEL('X')). This fix removes the parentheses before calling SplitLineFields.
@giacomolamanna
Copy link
Author

Hi, just wondering if you had a chance to take a look at this PR. Let me know if there’s anything I should adjust or improve.
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant