Skip to content

GPII-2106: Workaround to close firefox when keying-out elaine #577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amb26 merged 2 commits into from
Dec 7, 2017
Merged

GPII-2106: Workaround to close firefox when keying-out elaine #577

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dae7f39
GPII-2106: Workaround to close firefox when keying-out elaine
javihernandez Dec 7, 2017
7a2e35a
GPII-2106: Referenced the issue from the solutions registry
javihernandez Dec 7, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions gpii/node_modules/settingsHandlers/src/NoSettingsHandler.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 9 additions & 2 deletions testData/solutions/win32.json5
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1762,10 +1762,17 @@
],
"stop": [
{
"type": "gpii.windows.closeProcessByName",
"filename": "firefox.exe"
"type": "gpii.windows.closeProcessByName",
"filename": "firefox.exe"
}
],
// Although there are no settings to deal with, we need to pass through
// the "configure" action in order to proceed with the "stop" directive
// when keying out. This is a current limitation of the system, you can
// check https://issues.gpii.net/browse/GPII-2106 and
// https://issues.gpii.net/browse/GPII-1235 for more detailed information.
//
"configure": [ "settings.configure" ],
"isInstalled": [
{
"type": "gpii.deviceReporter.alwaysInstalled"
Expand Down