-
Notifications
You must be signed in to change notification settings - Fork 2
feat: ✨ Static Assets standalone servers with fileRead #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for TypeScript configuration path handling throughout the static asset processing system and enhances the content type system to distinguish between text and binary assets. It allows consuming projects to provide their own tsconfig.json path and introduces a readFileString method for extracting text content from static assets.
- Enhanced TypeScript syntax checking to accept custom tsconfig paths
- Extended content type definitions to include
isTextflag for distinguishing text from binary assets - Added
readFileStringfunctionality to static servers for reading text content from assets
Reviewed Changes
Copilot reviewed 22 out of 27 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/utils/syntax-checker.ts | Updated parameter naming and file extension validation to support more JS/TS variants |
| src/utils/input-path-verification.ts | Added tsConfigPath parameter to validation functions |
| src/utils/content-types.ts | Added isText flag to content type definitions and updated TypeScript content type |
| src/server/static-assets/static-server/types.ts | Enhanced server interfaces with readFileString method and route prefix support |
| src/server/static-assets/static-server/static-server.ts | Implemented readFileString method and enhanced asset path resolution |
| src/server/static-assets/asset-loader/inline-asset/types.ts | Added isText property to asset metadata and getText method to StaticAsset interface |
| src/server/static-assets/asset-loader/inline-asset/inline-asset.ts | Implemented getText method for extracting text content from assets |
| src/cli/fastedge-build/build.ts | Added tsconfig command line option support |
| integration-tests/fastedge-build.test.js | Updated tests to handle expanded file extension support |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Allow for combining multiple static asset manifests and serving or reading content. allow consuming project to provide tsconfig
2f85851 to
750edb3
Compare
|
🎉 This PR is included in version 1.3.0-alpha.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Allow for combining multiple static asset manifests and serving or reading content.
allow consuming project to provide tsconfig