Skip to content

Conversation

@godronus
Copy link
Collaborator

Allow for combining multiple static asset manifests and serving or reading content.

allow consuming project to provide tsconfig

@godronus godronus requested a review from Copilot September 22, 2025 18:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for TypeScript configuration path handling throughout the static asset processing system and enhances the content type system to distinguish between text and binary assets. It allows consuming projects to provide their own tsconfig.json path and introduces a readFileString method for extracting text content from static assets.

  • Enhanced TypeScript syntax checking to accept custom tsconfig paths
  • Extended content type definitions to include isText flag for distinguishing text from binary assets
  • Added readFileString functionality to static servers for reading text content from assets

Reviewed Changes

Copilot reviewed 22 out of 27 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/utils/syntax-checker.ts Updated parameter naming and file extension validation to support more JS/TS variants
src/utils/input-path-verification.ts Added tsConfigPath parameter to validation functions
src/utils/content-types.ts Added isText flag to content type definitions and updated TypeScript content type
src/server/static-assets/static-server/types.ts Enhanced server interfaces with readFileString method and route prefix support
src/server/static-assets/static-server/static-server.ts Implemented readFileString method and enhanced asset path resolution
src/server/static-assets/asset-loader/inline-asset/types.ts Added isText property to asset metadata and getText method to StaticAsset interface
src/server/static-assets/asset-loader/inline-asset/inline-asset.ts Implemented getText method for extracting text content from assets
src/cli/fastedge-build/build.ts Added tsconfig command line option support
integration-tests/fastedge-build.test.js Updated tests to handle expanded file extension support

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Allow for combining multiple static asset manifests and serving or reading content.

allow consuming project to provide tsconfig
@godronus godronus force-pushed the feature/static-assets branch from 2f85851 to 750edb3 Compare September 22, 2025 18:25
@godronus godronus requested a review from qrdl September 22, 2025 18:26
@godronus godronus merged commit 56d8d42 into main Sep 23, 2025
3 checks passed
@godronus godronus deleted the feature/static-assets branch September 23, 2025 07:53
@github-actions
Copy link

🎉 This PR is included in version 1.3.0-alpha.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions
Copy link

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants