Sync query param in list pages #13
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the list pages for events, organizations, and features to synchronize the pagination query parameters with the URL using nuqs' useQueryState, replacing the previous local state management with a query‐parameter approach.
- Replace useState with useQueryState for pagination state
- Rename pagination setter prop from updatePagination to setPagination
- Update related type definitions for search parameters in EventList and API calls
Reviewed Changes
Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/dashboard/event/page.tsx | Converted pagination state to useQueryState and updated the setter |
| src/pages/dashboard/organization/page.tsx | Converted pagination state to useQueryState and updated the setter |
| src/pages/dashboard/feature/components/FeatureList/index.tsx | Updated pagination prop name and type definitions for consistency |
| src/pages/dashboard/event/components/EventList/index.tsx | Adjusted pagination props and removed use of updatePagination |
| src/pages/dashboard/organization/components/OrganizationList/index.tsx | Adjusted pagination props and removed use of updatePagination |
| src/pages/dashboard/feature/index.tsx | Converted pagination state to useQueryState and updated the setter |
| src/pages/dashboard/layout.tsx | Minor formatting updates and wrapped Outlet with NuqsAdapter |
| src/api/dashboard/event.ts | Updated pagination parameter types in API call |
Files not reviewed (1)
- package.json: Language not supported
Member
|
LGTM |
|
🚀 预览部署完成！
由 GitHub Actions 自动生成 |
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modified in these pages:
finish #11