-
-
Notifications
You must be signed in to change notification settings - Fork 55
Add zoom factor #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add zoom factor #39
Conversation
alexk111
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the zoom-factor branch was created from the Release 2.6.0 branch instead of master. This will merge all of the Rel 2.6.0 changes with the zoom-factor ones.
This also makes it impossible to see the code changes made for that specific feature.
|
@alexk111 Done! |
|
Thanks for the update! You may reproduce the problem by copy-pasting a webpage widget instance and setting different zoom factors for them. Quote from https://www.electronjs.org/docs/latest/api/webview-tag
|
|
True, but this could be worked around by setting custom CSS per webview:
html { zoom: 80%; }
|
|
Yup, had the same idea :) Will try it a bit later. |
|
Experimented with the CSS zoom property. It scales elements and triggers layout recalculations, but does not scale the viewport. As a result, @media queries do not respond as expected, since the document's viewport dimensions remain unchanged. |
|
@alexk111 So what do you propose? Maybe, to keep it simple, just store a hash table of zoom per domain in the store: |
|
Since applying a zoom factor on a per-widget basis isn't possible, and its state is managed by Chromium, I implemented it as a context menu action rather than a widget setting. The change has already been merged into master. |
|
Thanks!
|
I've added the zoom factor (50%-300%) in the Webpage settings.
This branch is based on the Release 2.6.0-beta, for changes see the last commit.