upgrade to null safety

[lslv1243]

I made the required changes for the package to be sound null safe.
Since it depended on Pigment which the last update was 2 years ago, to not cause any breaking change, I inlined the function that is being used. The function only parses a string as Color.

[Curvel]

@mendieta any plans on merging and publishing the null safety version?

[mendieta]

Sorry, I'll merge during this week.

Cheers

[cyberpwnn]

Cool. Need this.

[Curvel]

@mendieta any updates here? Would be great to get the null safety release :D

[paulinventome]

Sorry - another request - can we merge the changes for null safety - this is the last package i need for me! thank you!!!

[beevelop]

Looking forward to this 👍

[JamesMcIntosh]

@mendieta Guessing you're busy but any chance of merging and releasing?

[AhmedNourJamalElDin]

Merge please.

[mx1up]

lgtm. use of late could have been prevented, i guess..

[TNorbury]

Looks like Pigment has been updated to null-safety: bregydoc/pigment@eb95e5e

[lslv1243]

@mx1up removed unnecessary late
@TNorbury using Pigment again instead of copying colorFromString function

[mx1up]

I was actually thinking just

TinyColor(Color color)
      : this.originalColor = color,
      _color = Color.fromARGB(alpha, red, green, blue);

or is that bad practice somehow? :) the extension seems overkill, just for the internals of a constructor. Or do you believe it is generally useful? Personally I haven't had the need yet.

[lslv1243]

It would actually be (reference color):

TinyColor(Color color)
      : this.originalColor = color,
      _color = Color.fromARGB(color.alpha, color.red, color.green, color.blue);

I don't think it is overkill, since the extension is private.
I am used to creating extensions for these cases to simplify the constructor and improve formatting, but it is just a matter of taste.
Both ways will produce the same end result, as of before, it was allowing the variable to not be initialized if somebody was to change the constructor and probably adding a tiny runtime penalty.

[mx1up]

yes, I forgot the color ref.
sorry, I did not realize it was a private extension. thanks for explaining

[savadodesigns]

Please merge, thanks 😃

[yc-codes]

Merge, Please

[savadodesigns]

Sorry, I'll merge during this week.

Cheers

Hi @mendieta, could you please merge :)

[nfriend]

Would love to see this merged as well! 🙏

In the meantime, I'm going to try migrating my codebase to null safety by depending on @lslv1243's latest commit in my pubspec.yaml like this:

dependencies:
  tinycolor:
    git:
      url: git@github.com:lslv1243/tinycolor.git
      ref: 87f654ce7b79daddfbe7cdf7b7d9bb27574a8b89

I haven't actually migrated yet, but running flutter pub outdated --mode=null-safety seems to indicated that this works:

❯ flutter pub outdated --mode=null-safety
Showing dependencies that are currently not opted in to null-safety.
[✗] indicates versions without null safety support.
[✓] indicates versions opting in to null safety.

All your dependencies declare support for null-safety.

[calvintam236]

Hey @lslv1243, can you make a PR to community-forked repo? Thanks!

[calvintam236]

Hey @lslv1243, can you make a PR to community-forked repo? Thanks!

Hey @lslv1243, please let us know if you are too busy to make the PR. We can work on it if that’s the case.