[BUGFIX] prevent double encoded sourceset urls #1678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamelessCoder
force-pushed
the
development
branch
3 times, most recently
from
7b35850 to
50d769b
Compare
luzat
approved these changes
Aug 5, 2022
Contributor
There was a problem hiding this comment.
This is similar (albeit updated) to my previously proposed solution and I don't see this change having the ability to break anything, but to fix the double-encoding for sure. @NamelessCoder Would it possible to review and merge this? The issue now exists for 4+ years and does have a simple fix.
NamelessCoder
force-pushed
the
development
branch
5 times, most recently
from
6dec417 to
74596bf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1674