Adds support for external image urls #1470
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally managed to create a pull request. This pull request fixes #1439.
What I did is add a check whether we are dealing with an already fully qualified URI or not (
if (isset($parsedSrc['host']))). Theelsepart is the function as it was before. This implementation is inspired by what TYPO3 Core does: https://github.com/TYPO3-CMS/extbase/blob/96fffc2b245dc29a78bcb06a64cdb9d138f169c9/Classes/Service/ImageService.php#L84-L103This of course does not add full support for FAL (e.g. no image processing), but it enables fully qualified URIs to be used in frontend and backend.