Skip to content

Conversation

@baldurh
Copy link

@baldurh baldurh commented Jun 12, 2025

Fixes #1125

Changes the AttributeError message in Resolver.__getattr__ so that it does not include the object values.

Copy link
Contributor

@kingbuzzman kingbuzzman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baldurh
Copy link
Author

baldurh commented Jun 18, 2025

@kingbuzzman thanks for reviewing this. What else is needed for getting this in?

@kingbuzzman
Copy link
Contributor

for @rbarrois to have some time 🤣😇 🤞

@kingbuzzman
Copy link
Contributor

I currently got 2 PRs open, for about a month now, he's usually around, he must be really busy.. him and @francoisfreitag

@baldurh
Copy link
Author

baldurh commented Jun 18, 2025

Thanks for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Factory Boy stringifies models during factory initialisations with Trait params

2 participants