Feat/ascii to netcdf with cavity #232
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The old logic (cav_nod_lev != 1) only caught level-2 cavities. After subtracting 1 from cavity_nlvls.out values, nodes with deeper cavity levels (e.g., 17 in file -> 16 after -1) were incorrectly marked as non-cavity. Changed to (cav_nod_lev > 0) which correctly identifies all cavity nodes: value 0 means surface level (no cavity), value > 0 means cavity present. Tested with CORE3 mesh: correctly identifies 4,627 cavity nodes instead of the previous 210,941 (almost all nodes).
Resolved conflicts by keeping logger from main branch. The cavity mask fix (cav_nod_lev != 0) is equivalent to the previous fix (cav_nod_lev > 0) for non-negative integers.
Contributor
Author
|
Already fixed by @FinnHeu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.